luminous: fsck: cid is improperly matched to oid #24705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used by bluestore fsck to ensure we're looking at the right collection. It needs to validate both that the pool id matches the object (including the temp objects) and that the hash matches; we were only checking the hash before. Fixes: http://tracker.ceph.com/issues/32731 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 0bd2546)
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit cf4a4eb)
Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 0c75020)
|
@xiexingguo In the mimic backport of this fix, you asked to include the fix for http://tracker.ceph.com/issues/36099 but I did not include it here because it touches code that is not present in luminous. |
xiexingguo
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/36145