ceph-volume-client: allow setting mode of CephFS volumes #24839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tombarron LGTM. Would volume group creation also need this? |
volume groups, snapshots, and snapshot groups. Signed-off-by: Tom Barron <tpb@dyncloud.net>
|
Thanks, Tom |
|
@batrick , can you please test the latest patchset? |
|
retest this please |
Sure. |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Nov 22, 2018
* refs/pull/24839/head: ceph-volume-client: allow setting mode of CephFS volumes Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
|
Is this ready for merge? |
|
Planning to merge this week after verifying test results. |
batrick
added a commit
that referenced
this pull request
Nov 27, 2018
* refs/pull/24839/head: ceph-volume-client: allow setting mode of CephFS volumes Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
|
We need to get this back to luminous (via mimic?) and downstream into 3.2. |
openstack-gerrit
pushed a commit
to openstack/manila
that referenced
this pull request
Jan 30, 2019
Corresponding ceph_volume_client PR [1] [1] ceph/ceph#24839 Depends-on: https://review.openstack.org/#/c/630221/ Change-Id: Iad78b8cc25c34d3675cd38ce9c757ad0e411b613
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Jan 30, 2019
* Update manila from branch 'master'
- Merge "Set mode for CephFS volumes and snapshots"
- Set mode for CephFS volumes and snapshots
Corresponding ceph_volume_client PR [1]
[1] ceph/ceph#24839
Depends-on: https://review.openstack.org/#/c/630221/
Change-Id: Iad78b8cc25c34d3675cd38ce9c757ad0e411b613
openstack-gerrit
pushed a commit
to openstack/manila
that referenced
this pull request
Feb 13, 2019
Corresponding ceph_volume_client PR [1] [1] ceph/ceph#24839 Depends-on: https://review.openstack.org/#/c/634028/ Change-Id: Iad78b8cc25c34d3675cd38ce9c757ad0e411b613 (cherry picked from commit 721bb70)
openstack-gerrit
pushed a commit
to openstack/manila
that referenced
this pull request
Feb 19, 2019
Corresponding ceph_volume_client PR [1] [1] ceph/ceph#24839 Depends-on: https://review.openstack.org/#/c/634028/ Change-Id: Iad78b8cc25c34d3675cd38ce9c757ad0e411b613 (cherry picked from commit 721bb70) (cherry picked from commit 4831c62)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and snapshots and snapshot groups.
OpenStack Manila needs this capability when it is used as a Kubernetes dynamic external storage provider.
Needed-by: https://review.openstack.org/#/c/614332/
Fixes: https://tracker.ceph.com/issues/36651
Signed-off-by: Tom Barron tpb@dyncloud.net