Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-volume systemd import main so console_scripts work for executable #24840

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@alfredodeza
Copy link
Contributor

commented Oct 30, 2018

ceph-volume systemd import main so console_scripts work for executable
Signed-off-by: Alfredo Deza <adeza@redhat.com>

@alfredodeza alfredodeza requested a review from andrewschoen Oct 30, 2018

@leseb

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

This is breaking ceph-ansible testing on master, please merge ASAP.

@alfredodeza

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

@leseb we had to wait for functional tests for this change using built packages for this branch to avoid the issue that got us here in the first place. Happy to hear that ceph-ansible is finally testing development branches though!

All non-simple tests passed with this branch https://jenkins.ceph.com/job/ceph-volume-test/58/

@alfredodeza alfredodeza merged commit 7aaf02b into master Oct 31, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@alfredodeza alfredodeza deleted the wip-rm36648 branch Oct 31, 2018

@leseb

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

@alfredodeza thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.