mgr/dashboard: Show/Hide Grafana tabs according to user role #24851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2batic
requested review from
tspmelo,
alfonsomthd,
ricardoasmarques and
epuertat
a2batic
force-pushed
the
grafana-roles
branch
2 times, most recently
from
4fd81cd
to
218fd37
Compare
votdev
requested changes
Oct 31, 2018
| if msg: | ||
| response['message'] = msg | ||
| def url(self): | ||
| # grafana = GrafanaRestClient.instance() |
There was a problem hiding this comment.
You can remove the commented code. You can use the git history to see the previous implementation if needed.
a2batic
force-pushed
the
grafana-roles
branch
from
218fd37
to
4ff3e41
Compare
|
jenkins retest this please |
tspmelo
suggested changes
Nov 5, 2018
src/pybind/mgr/dashboard/frontend/src/app/ceph/cephfs/cephfs-detail/cephfs-detail.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.html
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.ts
Outdated
Show resolved
Hide resolved
a2batic
force-pushed
the
grafana-roles
branch
from
4ff3e41
to
7eca099
Compare
a2batic
force-pushed
the
grafana-roles
branch
2 times, most recently
from
c33f446
to
c6f14ac
Compare
|
jenkins retest this please |
|
All comments have been addressed. |
votdev
approved these changes
Nov 9, 2018
tspmelo
approved these changes
Nov 13, 2018
alfonsomthd
approved these changes
Nov 15, 2018
epuertat
approved these changes
Nov 15, 2018
a2batic
force-pushed
the
grafana-roles
branch
from
c6f14ac
to
e26f68b
Compare
Fixes: http://tracker.ceph.com/issues/36655 Signed-off-by: Kanika Murarka <kmurarka@redhat.com>
a2batic
force-pushed
the
grafana-roles
branch
from
e26f68b
to
a84bed2
Compare
|
jenkins retest this please |
|
QA run passed: http://pulpito.ceph.com/laura-2018-11-19_16:38:21-rados:mgr-wip-lpaduano-testing-24851-2-distro-basic-mira/ (included QA fix PR #25149 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/36655
Signed-off-by: Kanika Murarka kmurarka@redhat.com