New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: radosgw-admin user stats are incorrect when dynamic re-sharding is enabled #24911

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

smithfarm commented Nov 3, 2018

cbodley added some commits Oct 15, 2018

rgw: cls_user_set_buckets_info can update bucket id
if cls_user_set_bucket_info() finds an existing bucket entry, it does
not update its bucket id

Fixes: https://tracker.ceph.com/issues/24505

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit e1b97fc)
rgw: rgw_user_sync_all_stats uses bucket entrypoint
when bucket reshard completes, rgw_link_bucket() passes the new bucket
instance id down to cls_user, but cls_user_set_buckets_info() does not
change the instance id when it's updating an existing bucket. so when
rgw_user_sync_all_stats() looks up each of the user's buckets, it uses
the original bucket instance id instead of the resharded one and
calculates user stats that may not match the current bucket stats

as a workaround, rgw_user_sync_all_stats() no longer relies on the
bucket instance id it gets from rgw_read_user_buckets(), and instead
calls get_bucket_info() to look up the current instance in the bucket
entrypoint

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit b33328f)

@smithfarm smithfarm added this to the mimic milestone Nov 3, 2018

@smithfarm smithfarm added the rgw label Nov 3, 2018

@smithfarm smithfarm requested review from mattbenjamin and cbodley Nov 3, 2018

@smithfarm smithfarm changed the title mimic: radosgw-admin user stats are incorrect when dynamic re-sharding is enabled mimic: rgw: radosgw-admin user stats are incorrect when dynamic re-sharding is enabled Nov 3, 2018

@cbodley

cbodley approved these changes Nov 5, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 19, 2018

@yuriw yuriw merged commit aaa9e32 into ceph:mimic Nov 20, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-36535-mimic branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment