New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rbd: TokenBucketThrottle: use reference to m_blockers.front() and then update it. #24915

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

smithfarm commented Nov 3, 2018

TokenBucketThrottle: use reference to m_blockers.front() and then upd…
…ate it

As we need to update the blocker below, then we need to use reference to front object,
rather than a new object of blocker.

Fixes: http://tracker.ceph.com/issues/36475
Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
(cherry picked from commit 9a2b1f2)

@smithfarm smithfarm added this to the mimic milestone Nov 3, 2018

@smithfarm smithfarm added the rbd label Nov 3, 2018

@smithfarm smithfarm requested a review from dillaman Nov 3, 2018

@smithfarm smithfarm changed the title mimic: TokenBucketThrottle: use reference to m_blockers.front() and then update it. mimic: rbd: TokenBucketThrottle: use reference to m_blockers.front() and then update it. Nov 3, 2018

@dillaman
Copy link
Contributor

dillaman left a comment

👍

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 20, 2018

@yuriw yuriw merged commit 1da94d9 into ceph:mimic Nov 22, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-36529-mimic branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment