New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: FAILED assert(osdmap_manifest.pinned.empty()) in OSDMonitor::prune_init() #24918

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

smithfarm commented Nov 3, 2018

mon/OSDMonitor: don't change in-memory state on prune
We were modifying the in-memory state when running through several
osdmap pruning functions.

Should the transaction we're encoding not be committed, we may end up in
a state where we have a stale in-memory state that does not match what
is on disk; including having in-memory state while not having on-disk
state.

We prevent this sort of inconsistency by working on temporary states
instead.

Fixes: http://tracker.ceph.com/issues/24612

Signed-off-by: Joao Eduardo Luis <joao@suse.de>
(cherry picked from commit 8aa7590)

Conflicts:
	src/mon/OSDMonitor.cc
- mimic has g_conf where master has g_conf()

@smithfarm smithfarm changed the title mimic: FAILED assert(osdmap_manifest.pinned.empty()) in OSDMonitor::prune_init() mimic: core: FAILED assert(osdmap_manifest.pinned.empty()) in OSDMonitor::prune_init() Nov 3, 2018

@smithfarm smithfarm requested review from jecluis and liewegas Nov 3, 2018

@smithfarm smithfarm added the core label Nov 3, 2018

@smithfarm smithfarm added this to the mimic milestone Nov 3, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 16, 2018

@yuriw yuriw merged commit c155489 into ceph:mimic Nov 26, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-35071-mimic branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment