New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: objecter cannot resend split-dropped op when racing with con reset #24970

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
5 participants
@smithfarm
Copy link
Contributor

smithfarm commented Nov 7, 2018

osdc/Objecter: fix split vs reconnect race
If we are reconnecting to an OSD, we may not have a connection established
so this feature check is completely unreliable.  If there happens to be a
split, that could mean we don't resend an op that should have been resent.

Instead, we can infer the OSD has the new behavior if require_osd_release
is luminous or later.  If not, we can look at the per-osd features in the
OSDMap.

Fixes: http://tracker.ceph.com/issues/22544
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 917fdbe)

@smithfarm smithfarm added this to the mimic milestone Nov 7, 2018

@smithfarm smithfarm added the core label Nov 7, 2018

@smithfarm smithfarm changed the title mimic: objecter cannot resend split-dropped op when racing with con reset mimic: core: objecter cannot resend split-dropped op when racing with con reset Nov 7, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 16, 2018

@yuriw yuriw merged commit bf0d322 into ceph:mimic Nov 26, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-35843-mimic branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment