New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: doc: Put command template into literal block #25000

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@MrStupnikov
Copy link

MrStupnikov commented Nov 8, 2018

ceph-deploy osd create --data {device} {ceph-node} command
is not displayed properly because of missing double colons. As a result, double en dash is translated to single en dash [1]

[1] http://docs.ceph.com/docs/mimic/start/quick-ceph-deploy/

@MrStupnikov MrStupnikov force-pushed the MrStupnikov:mimic-docfix-1358 branch 3 times, most recently from 6441842 to 169922d Nov 8, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Nov 15, 2018

see also #24999 and #25001

@tchaikov tchaikov added this to the mimic milestone Nov 15, 2018

@smithfarm
Copy link
Contributor

smithfarm left a comment

same comment as #25001

mimic: doc: put command template into literal block
``ceph-deploy osd create --data {device} {ceph-node}`` command
is not displayed properly because of missing double colons.

Signed-off-by: Alexey Stupnikov <aleksey.stupnikov@gmail.com>
(cherry picked from commit bff5a21)

@MrStupnikov MrStupnikov force-pushed the MrStupnikov:mimic-docfix-1358 branch from 169922d to 8ae28c0 Nov 17, 2018

@MrStupnikov

This comment has been minimized.

Copy link

MrStupnikov commented Nov 17, 2018

@tchaikov @smithfarm thank you for your reviews. Pushed proper commit message.

@smithfarm smithfarm merged commit 042dc58 into ceph:mimic Nov 27, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment