New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: monstore tool rebuild does not generate creating_pgs #25016

Merged
merged 5 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

smithfarm commented Nov 10, 2018

liewegas added some commits Oct 9, 2018

ceph-monstore-tool: rebuild: remove obsolete pgmap_meta fields
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 04bbf0c)
ceph-monstore-tool: rebuild creating_pgs
In particular, we need to rebuild the created_pools set or else the mon
will try to recreate every PG in the system.  On an aged cluster, that
is extremely expensive, and will break things.

Fixes: http://tracker.ceph.com/issues/36306
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 0182931)
ceph-monstore-tool: remove remaining pgmap references, inflate-pgmap …
…command

These are all also obsolete.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 375585a)

Conflicts:
	src/tools/ceph_monstore_tool.cc
- inflate_pgmap, which is being removed, does not match the master
version byte-for-byte
ceph-objectstore-tool: update-mon-db: remove pgmap references
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a936975)

Conflicts:
	src/tools/rebuild_mondb.cc
- update_pgmap_pg, which is being removed, does not match the master
version byte-for-byte
doc/rados/troubleshooting: update notes on rebuilding mon db
- those old pg settings are no longer lost as they go in the OSDMap now
- add a note about pools that were mid-create

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 3a4af5d)

@smithfarm smithfarm changed the title mimic: monstore tool rebuild does not generate creating_pgs mimic: core: monstore tool rebuild does not generate creating_pgs Nov 10, 2018

@smithfarm smithfarm requested review from tchaikov and liewegas Nov 10, 2018

@smithfarm smithfarm added this to the mimic milestone Nov 10, 2018

@smithfarm smithfarm added the core label Nov 10, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 16, 2018

@yuriw yuriw merged commit 33b2c90 into ceph:mimic Nov 26, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-36433-mimic branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment