New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: core: mon osdmap cash too small during upgrade to mimic #25019

Merged
merged 4 commits into from Nov 26, 2018

Conversation

@smithfarm
Copy link
Contributor

smithfarm commented Nov 10, 2018

liewegas added some commits Sep 24, 2018

mon: mon_osd_cache_size = 500 (from 10)
10 maps is too small to enable all mon sessions to keep abreast of the
latest maps, especially if OSDs are down for any period of time during an
upgrade.

Note that this is quite a bit larger, but the memory usage of the mon will
scale proportionally to the size of the cluster: 500 small osdmaps is not
a significant amount of RAM, while conversely having a large cache is
most important on a large cluster and those mons will generally have
plenty of RAM available.

Someday we should control this with a memory envelope like we do with the
OSDs, but that remains future work.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 1ce6429)
rocksdb: increase default cache size to 512 MB
For filestore OSDs, this is probably a good idea anyway, and is generally
not going to be hugely impactful on the memory footprint (where users
have been told to provide 1 GB RAM per 1 TB storage for a long time now).

For bluestore OSDs, this value is meaningless as we're autotuning this
anyway.

For mons, this is a more reasonable default.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit cbfc3ee)

Conflicts:
	src/common/options.cc
- trivial resolution
doc/start/hardware-recommendations: refresh recommendations for RAM
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 6af6127)
PendingReleaseNotes: add note about increased mon memory footprint
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 2e66381)

Conflicts:
	PendingReleaseNotes

@smithfarm smithfarm self-assigned this Nov 10, 2018

@smithfarm smithfarm added this to the mimic milestone Nov 10, 2018

@smithfarm smithfarm changed the title mimic: mon osdmap cash too small during upgrade to mimic mimic: core: mon osdmap cash too small during upgrade to mimic Nov 10, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 16, 2018

@yuriw yuriw merged commit de445bc into ceph:mimic Nov 26, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-36505-mimic branch Nov 26, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Nov 27, 2018

@gregsfortytwo I guess your question at #25021 (comment) applied here, too?

@gregsfortytwo

This comment has been minimized.

Copy link
Member

gregsfortytwo commented Nov 28, 2018

Probably, although as it's earlier in the release lifetime it's a little less worrying to me. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment