New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: cephfs: some tool commands silently operate on only rank 0, even if multiple ranks exist #25036

Merged
merged 4 commits into from Nov 22, 2018

Conversation

Projects
None yet
4 participants
@smithfarm
Copy link
Contributor

smithfarm commented Nov 10, 2018

vshankar added some commits Jul 23, 2018

cephfs-journal-tool: dump to per rank output file wherever necessary
cephfs-journal-tool supports operations on all ranks. Operations
such as dump/export do not write to distinct filenames hence
overwriting the data dumped or exported for the previous rank.

With this change (and further commits), for operations on all
ranks, dump/export would write to distinct filenames suffixed
by the mds rank (.0, .1, etc..). For operations on a single rank
or if there exist a single rank, the passed in filename is used
as it is.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit cb19db7)
cephfs-journal-tool: pass local arg vector for Journal actions
Some helper functions clobber the passed in arg vector. This
causes operations on all but the first rank to fail as the
operations for the first rank tampers with the arg vector.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit d5e482a)
cephfs-journal-tool: make "--rank" argument mandatory
... and do not silenty act on the default filesystem.
Force users to specify the filesystem name and rank.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 5e4702e)
test: make rank argument mandatory when running journal_tool
Also, fix a bunch of quirky journal_tool invocations that pass
"--rank" argument as the command argument rather than passing it
as function argument.

Fixes: https://tracker.ceph.com/issues/24780
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit f65193d)

@smithfarm smithfarm self-assigned this Nov 10, 2018

@smithfarm smithfarm added this to the mimic milestone Nov 10, 2018

@smithfarm smithfarm changed the title mimic: Some cephfs tool commands silently operate on only rank 0, even if multiple ranks exist mimic: cephfs: some tool commands silently operate on only rank 0, even if multiple ranks exist Nov 10, 2018

@smithfarm smithfarm requested a review from batrick Nov 10, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 16, 2018

@ukernel ukernel self-requested a review Nov 17, 2018

@yuriw yuriw merged commit f915530 into ceph:mimic Nov 22, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-36218-mimic branch Nov 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment