New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: tests: make readable.sh fail if it doesn't run anything #25050

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@gregsfortytwo
Copy link
Member

gregsfortytwo commented Nov 12, 2018

We want to detect if "make check" is run in an environment where some tests are skipped due to
missing data, so we now fail if we don't get a ceph object corpus.

test: make readable.sh fail if it doesn't run anything
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
(cherry picked from commit 6623963)

@gregsfortytwo gregsfortytwo added the tests label Nov 12, 2018

@gregsfortytwo gregsfortytwo added this to the mimic milestone Nov 12, 2018

@smithfarm smithfarm changed the title test: make readable.sh fail if it doesn't run anything mimic: test: make readable.sh fail if it doesn't run anything Nov 15, 2018

@smithfarm smithfarm changed the title mimic: test: make readable.sh fail if it doesn't run anything mimic: tests: make readable.sh fail if it doesn't run anything Nov 15, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 23, 2018

@gregsfortytwo @smithfarm what suite to we run on this ?

@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Nov 23, 2018

@yuriw This PR is exercised by "make check" only.

@smithfarm smithfarm merged commit 7627c21 into ceph:mimic Nov 23, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 23, 2018

@smithfarm copy and thx !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment