Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous ceph-volume: patch Device when testing #25067

merged 2 commits into from Nov 13, 2018


None yet
3 participants
Copy link

alfredodeza commented Nov 12, 2018

PR #24859 introduced unit tests that cause failures on systems without LVM.

Backport of: #25063

alfredodeza added some commits Nov 12, 2018

ceph-volume tests inventory should patch before using .get_devices()
Signed-off-by: Alfredo Deza <>
(cherry picked from commit 7ee7a59)
ceph-volume tests patch Device() by splitting parametrized method
This was causing failures on systems where there is no LVM or where the
device names don't match. Patching is always recommended to avoid
conflicts with the system testing

Signed-off-by: Alfredo Deza <>
(cherry picked from commit 82d96f8)

@ceph-jenkins ceph-jenkins added this to the luminous milestone Nov 12, 2018

@alfredodeza alfredodeza requested review from jan--f and andrewschoen Nov 12, 2018

@andrewschoen andrewschoen merged commit 28f9647 into ceph:luminous Nov 13, 2018

5 checks passed

Docs: build check OK - docs built
Signed-off-by all commits in this PR are signed
Unmodified Submodules submodules for project are unmodified
ceph-volume tox tests OK
make check make check succeeded

@alfredodeza alfredodeza deleted the alfredodeza:luminous-rm36768 branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.