New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic ceph-volume: reject devices that have existing GPT headers #25103

Merged
merged 6 commits into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@alfredodeza
Copy link
Contributor

alfredodeza commented Nov 14, 2018

This also combines the LVPath and ValidDevice arg validators so now all subcommands are using the same validator for devices.

Fixes: http://tracker.ceph.com/issues/27062
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1644321
Backport of: #25098

andrewschoen added some commits Nov 13, 2018

ceph-volume: add PTTYPE to blkid parser
Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Resolves: rm#27062
(cherry picked from commit 3d86d2d)
ceph-volume: adds has_gpt_headers property to Device class
Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Resolves: rm#27062
(cherry picked from commit 568a0ce)
ceph-volume: combine the LVPath arg validator with ValidDevice
This combines the two arg validators and makes both batch and
prepare/active both use ValidDevice.

This will also allow us to use lvs with a full path, like
/dev/vg/lv instead of always enforcing vg/lv.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Resolves: rm#27062
(cherry picked from commit d6a5a76)
ceph-volume: adds lv_name property to Device class
Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Resolves: rm#27062
(cherry picked from commit cc0317e)
ceph-volume: return lvs as vg/lv from ValidDevice if as_string is True
All code in prepare and activate expect lvs to be in that format.
Eventually we can refactor all that to use the Device class as well.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Resolves: rm#27062
(cherry picked from commit fdf7f3c)
ceph-volume: update tests after removing the LVPath arg validator
Signed-off-by: Andrew Schoen <aschoen@redhat.com>

Resolves: rm#27062
(cherry picked from commit 0cb95ac)

@ceph-jenkins ceph-jenkins added this to the mimic milestone Nov 14, 2018

@alfredodeza alfredodeza requested a review from andrewschoen Nov 14, 2018

@alfredodeza alfredodeza merged commit 26b8bde into ceph:mimic Nov 14, 2018

35 of 37 checks passed

ceph-volume simple testing xenial-bluestore-activate running
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain running
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-single_type OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt OK
Details
ceph-volume lvm testing centos7-bluestore-create OK
Details
ceph-volume lvm testing centos7-bluestore-dmcrypt OK
Details
ceph-volume lvm testing centos7-filestore-create OK
Details
ceph-volume lvm testing centos7-filestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-bluestore-create OK
Details
ceph-volume lvm testing xenial-bluestore-dmcrypt OK
Details
ceph-volume lvm testing xenial-filestore-create OK
Details
ceph-volume lvm testing xenial-filestore-dmcrypt OK
Details
ceph-volume simple testing centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain OK
Details
ceph-volume tox tests OK
Details
make check make check succeeded
Details

@alfredodeza alfredodeza deleted the alfredodeza:mimic-rm-27062 branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment