New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr: hold lock while accessing the request list and submittin request #25113

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
5 participants
@swinds24
Copy link
Contributor

swinds24 commented Nov 15, 2018

ceph-mgr: hold lock while accessing the request list and submitting r…
…equest

The request creation can fire up the notify event early and it can cause
a race condition where the actual request was not yet added to the
self.requests list which makes the submit_request() function waits
forever without accepting new requests.

https://marc.info/?l=ceph-devel&m=154104291714160&w=2

Fixes: https://tracker.ceph.com/issues/36764

Signed-off-by: Jerry Lee <leisurelysw24@gmail.com>
(cherry picked from commit b09aefc)

Conflicts:
	src/pybind/mgr/restful/module.py

@tchaikov tchaikov changed the title ceph-mgr: hold lock while accessing the request list and submittin request mimic: ceph-mgr: hold lock while accessing the request list and submittin request Nov 15, 2018

@tchaikov tchaikov added this to the mimic milestone Nov 15, 2018

@smithfarm smithfarm added the mgr label Nov 15, 2018

@smithfarm smithfarm requested a review from jcsp Nov 15, 2018

@smithfarm smithfarm changed the title mimic: ceph-mgr: hold lock while accessing the request list and submittin request mimic: mgr: hold lock while accessing the request list and submittin request Nov 15, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 20, 2018

@yuriw yuriw merged commit 5d082d2 into ceph:mimic Nov 22, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment