New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: build/ops: debian: correct ceph-common relationship with older radosgw package #25115

Merged
merged 1 commit into from Nov 22, 2018

Conversation

Projects
None yet
4 participants
@mcv21
Copy link
Contributor

mcv21 commented Nov 15, 2018

debian: correct ceph-common relationship with older radosgw package
Fixes: https://tracker.ceph.com/issues/37273

9fd30b9 moved
/etc/bash_completion.d/radosgw-admin from radosgw to ceph-common. This
means that if you try and install a newer ceph-common over an older
radosgw, there's a conflict, and the install fails:

```
Unpacking ceph-common (12.2.8-1xenial) over (10.2.9-0ubuntu0.16.04.1) ...
dpkg: error processing archive ceph-common_12.2.8-1xenial_amd64.deb (--install):
 trying to overwrite '/etc/bash_completion.d/radosgw-admin', which is also in package radosgw 10.2.9-0ubuntu0.16.04.1
```

Per Debian policy (
https://www.debian.org/doc/debian-policy/ch-relationships.html#overwriting-files-in-other-packages
) the correct way to handle a package taking over a file is for a
versioned Replaces and Breaks.

The change went into 12.0.3, so this commit adds Replaces and Breaks
against radosgw less than that version. It should be backported to
Luminous to avoid issues with upgrades from older versions (Jewel and
Kraken).

Signed-off-by: Matthew Vernon <mv3@sanger.ac.uk>
(cherry picked from commit dd24ddc)

@smithfarm smithfarm added this to the mimic milestone Nov 15, 2018

@smithfarm smithfarm changed the title debian: correct ceph-common relationship with older radosgw package mimic: build/ops: debian: correct ceph-common relationship with older radosgw package Nov 15, 2018

@smithfarm smithfarm added the build/ops label Nov 15, 2018

@smithfarm smithfarm requested a review from tchaikov Nov 15, 2018

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Nov 20, 2018

@yuriw yuriw merged commit c91f8ac into ceph:mimic Nov 22, 2018

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment