Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Add info to Pools table #25489

Merged
merged 1 commit into from Dec 17, 2018

Conversation

alfonsomthd
Copy link
Contributor

@alfonsomthd alfonsomthd commented Dec 11, 2018

  • Column 'Placement Groups' renamed to 'Pg Status':
    It shows PG states.
  • Created 'CephSharedModule' for shared services within ceph module.
  • Created PgCategoryService & PgCategory model (logic encapsulation).
  • Color consistency: PG chart (landing page) and cell text color are similar.

Fixes: https://tracker.ceph.com/issues/36740

Signed-off-by: Alfonso Martínez almartin@redhat.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new look 👍 and you already added a bunch of tests 😃

@alfonsomthd alfonsomthd force-pushed the 36740-add-info-to-pools-table branch 3 times, most recently from b29b211 to 018b36b Compare December 13, 2018 13:07
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alfonsomthd
Copy link
Contributor Author

@Devp00l Your latest suggestions have been applied.

@alfonsomthd alfonsomthd force-pushed the 36740-add-info-to-pools-table branch 2 times, most recently from 27a3c92 to 00df1c0 Compare December 14, 2018 16:29
Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally - lgtm!

@alfonsomthd
Copy link
Contributor Author

alfonsomthd commented Dec 17, 2018

jenkins retest this please

- Column 'Placement Groups' renamed to 'Pg Status':
It shows PG states.
- Created 'CephSharedModule' for shared services within ceph module.
- Created PgCategoryService & PgCategory model (logic encapsulation).
- Color consistency: PG chart (landing page) and cell text color are similar.

Fixes: https://tracker.ceph.com/issues/36740

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally - nice improvement!
peek 2018-12-17 15-44

@LenzGr LenzGr merged commit 066a039 into ceph:master Dec 17, 2018
alfonsomthd added a commit to rhcs-dashboard/ceph that referenced this pull request Dec 18, 2018
Updated API pool tests
as stats are enabled by default when retrieving the pool list
since:
ceph#25489

Fixes: https://tracker.ceph.com/issues/37704

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
@alfonsomthd alfonsomthd deleted the 36740-add-info-to-pools-table branch April 4, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants