New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: Add info to Pools table #25489
mgr/dashboard: Add info to Pools table #25489
Conversation
9926f0c
to
5fd3c46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new look 👍 and you already added a bunch of tests 😃
src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard/health/health.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/dashboard/health/health.component.ts
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.spec.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/pg-category.service.spec.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/pg-category.service.ts
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/pg-category.service.ts
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/shared/pg-category.service.ts
Show resolved
Hide resolved
b29b211
to
018b36b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
018b36b
to
e851bbb
Compare
|
@Devp00l Your latest suggestions have been applied. |
27a3c92
to
00df1c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally - lgtm!
|
jenkins retest this please |
- Column 'Placement Groups' renamed to 'Pg Status': It shows PG states. - Created 'CephSharedModule' for shared services within ceph module. - Created PgCategoryService & PgCategory model (logic encapsulation). - Color consistency: PG chart (landing page) and cell text color are similar. Fixes: https://tracker.ceph.com/issues/36740 Signed-off-by: Alfonso Martínez <almartin@redhat.com>
00df1c0
to
3fcdbdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated API pool tests as stats are enabled by default when retrieving the pool list since: ceph#25489 Fixes: https://tracker.ceph.com/issues/37704 Signed-off-by: Alfonso Martínez <almartin@redhat.com>

It shows PG states.
Fixes: https://tracker.ceph.com/issues/36740
Signed-off-by: Alfonso Martínez almartin@redhat.com