Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Changed background color of Masthead to brand gray #25628

Merged
merged 1 commit into from Dec 19, 2018
Merged

mgr/dashboard: Changed background color of Masthead to brand gray #25628

merged 1 commit into from Dec 19, 2018

Conversation

gnehapk
Copy link
Contributor

@gnehapk gnehapk commented Dec 19, 2018 •
edited

Fixes: http://tracker.ceph.com/issues/35690
Signed-off-by: Neha Gupta gnehapk@gmail.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Before -
masthead-changes-before

After -
masthead-changes-after

LenzGr
LenzGr approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@LenzGr LenzGr requested a review from Exotelis December 19, 2018 09:18
epuertat
epuertat approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok! Congrats, @gnehapk for your first contribution to Ceph!

@LenzGr LenzGr merged commit 44bd1a0 into ceph:master Dec 19, 2018
@LenzGr LenzGr added the cleanup label Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenzGr LenzGr LenzGr approved these changes

@votdev votdev votdev approved these changes

@epuertat epuertat epuertat approved these changes

@tspmelo tspmelo Awaiting requested review from tspmelo

@alfonsomthd alfonsomthd Awaiting requested review from alfonsomthd

@ricardoasmarques ricardoasmarques Awaiting requested review from ricardoasmarques

@Exotelis Exotelis Awaiting requested review from Exotelis

Assignees
No one assigned
Labels
cleanup dashboard needs-review
Projects
None yet
Milestone
No milestone
5 participants
@gnehapk @LenzGr @votdev @epuertat @a2batic