Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: always stop timer's thread when it is suspended #25714

Closed
wants to merge 1 commit into from

Conversation

@wp389
Copy link
Contributor

commented Dec 27, 2018

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

ticket:
https://tracker.ceph.com/issues/37766
signoff: wp389@126.com

@wp389 wp389 changed the title https://tracker.ceph.com/issues/37766 RADOS shutdown hang Dec 27, 2018

@wp389

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

ceph::timer may had some bug.

@tchaikov
Copy link
Contributor

left a comment

@wp389 could you update the commit message so that

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes. in this case, it'd be "common: ". please note, the title of the PR is not the one of the commit.

and summarize your change in the title of your commit message. and elaborate the details in the body of the commit message. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes

could you add a "Signed-off-by" line at the end of your commit message? "git commit -s" will do the trick for you. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#1-sign-your-work

and tag your commit using Fixes:, see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#tag-the-commit

@tchaikov tchaikov changed the title RADOS shutdown hang common: always stop timer's thread when it is suspended Dec 31, 2018

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

@wp389 ping

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2019

reposting this PR at #26469 to address the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.