Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
common: always stop timer's thread when it is suspended #25714
tchaikov left a comment •
@wp389 could you update the commit message so that
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes. in this case, it'd be "common: ". please note, the title of the PR is not the one of the commit.
and summarize your change in the title of your commit message. and elaborate the details in the body of the commit message. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes
could you add a "
and tag your commit using