mgr/dashboard: add columns to Pools table #25791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsomthd
requested review from
LenzGr,
votdev,
sebastian-philipp,
ricardoasmarques,
Devp00l,
callithea and
tspmelo
|
jenkins retest this please |
Devp00l
suggested changes
Jan 8, 2019
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.ts
Outdated
Show resolved
Hide resolved
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-list/pool-list.component.ts
Outdated
Show resolved
Hide resolved
alfonsomthd
force-pushed
the
36740-pool-stats-read-write-columns
branch
2 times, most recently
from
056edb8
to
6911ef9
Compare
* Added columns: Usage, Read bytes, Write bytes, Read ops, Write ops. * TableKeyValueComponent: Bugfix in method: _insertFlattenObjects * Updated jest global mock: Now window.getComputedStyle returns an object that has getPropertyValue defined (otherwise jest pool tests involving chart.js threw error). See: https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle Fixes: https://tracker.ceph.com/issues/37717 Fixes: https://tracker.ceph.com/issues/34320 Signed-off-by: Alfonso Martínez <almartin@redhat.com>
alfonsomthd
force-pushed
the
36740-pool-stats-read-write-columns
branch
from
6911ef9
to
d9404d6
Compare
Devp00l
approved these changes
Jan 9, 2019
LenzGr
approved these changes
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added columns:
Usage, Read bytes, Write bytes, Read ops, Write ops.
TableKeyValueComponent:
Bugfix in method: _insertFlattenObjects
Updated jest global mock:
Now window.getComputedStyle returns an object
that has getPropertyValue defined
(otherwise jest pool tests involving chart.js threw error). See:
https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle
Fixes: https://tracker.ceph.com/issues/37717
Fixes: https://tracker.ceph.com/issues/34320
Signed-off-by: Alfonso Martínez almartin@redhat.com