Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: mon: monstore tool rebuild does not generate creating_pgs #25825

Merged
merged 5 commits into from Feb 28, 2019

Conversation

Projects
None yet
6 participants
@pdvian
Copy link

commented Jan 7, 2019

liewegas added some commits Oct 9, 2018

ceph-monstore-tool: rebuild: remove obsolete pgmap_meta fields
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 04bbf0c)

Conflicts:
	src/tools/ceph_monstore_tool.cc : Removed update_pgmap_meta
ceph-monstore-tool: rebuild creating_pgs
In particular, we need to rebuild the created_pools set or else the mon
will try to recreate every PG in the system.  On an aged cluster, that
is extremely expensive, and will break things.

Fixes: http://tracker.ceph.com/issues/36306
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 0182931)
ceph-monstore-tool: remove remaining pgmap references, inflate-pgmap …
…command

These are all also obsolete.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 375585a)

Conflicts:
	src/tools/ceph_monstore_tool.cc : Removed inflate_pgmap
ceph-objectstore-tool: update-mon-db: remove pgmap references
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a936975)

Conflicts:
	src/tools/rebuild_mondb.cc : Removed update_pgmap_pg
doc/rados/troubleshooting: update notes on rebuilding mon db
- those old pg settings are no longer lost as they go in the OSDMap now
- add a note about pools that were mid-create

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 3a4af5d)

@batrick batrick added the mon label Jan 11, 2019

@batrick batrick added this to the luminous milestone Jan 11, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

jenkins re-test this please

@smithfarm smithfarm changed the title luminous: monstore tool rebuild does not generate creating_pgs luminous: mon: monstore tool rebuild does not generate creating_pgs Jan 16, 2019

@smithfarm smithfarm added the tools label Jan 16, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

@yuriw yuriw merged commit 4d6bb25 into ceph:luminous Feb 28, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@dzafman
Copy link
Member

left a comment

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.