Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: default osd_objectstore=bluestore #25937

Merged
merged 2 commits into from Jan 18, 2019
Merged

osd: default osd_objectstore=bluestore #25937

merged 2 commits into from Jan 18, 2019

Conversation

liewegas
Copy link
Member

@liewegas liewegas commented Jan 13, 2019 •
edited by smithfarm

  • change the default
  • fix standaloen and other tests

This replaces #24642

Fixes: http://tracker.ceph.com/issues/36494

@liewegas liewegas mentioned this pull request Jan 13, 2019
Closed
@liewegas
Copy link
Member Author

@vumrao @neha-ojha @jdurgin we could alternatively adjust the standalone tests to mount via fuse and fiddle that way, but this is easier and probably okay?

@jdurgin
Copy link
Member

jdurgin commented Jan 14, 2019

seems like much of the EIO testing would need to be different for bluestore, since it's detecting problems during reads. seems fine to keep these versions of the tests for filestore

@vumrao
Copy link
Contributor

vumrao commented Jan 14, 2019

Thank you, Josh and Sage, for your feedback.

@vumrao @liewegas
osd/objectstore: change osd_objectstore default to bluestore
200a8f2 
Fixes: http://tracker.ceph.com/issues/36494

Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
@vumrao @liewegas
qa: specify filestore for misc tests
8a694fc 
Signed-off-by: Vikhyat Umrao <vumrao@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas liewegas changed the title qa/standalone: fixes for bluestore default osd: defautl osd_objecstore=bluestore Jan 16, 2019
@liewegas
Copy link
Member Author

@vumrao this replaces your PR since it was fixing some of those patches. squashed all the test changes into one commit.

@liewegas liewegas changed the title osd: defautl osd_objecstore=bluestore osd: default osd_objecstore=bluestore Jan 16, 2019
@liewegas liewegas changed the title osd: default osd_objecstore=bluestore osd: default osd_objectstore=bluestore Jan 16, 2019
@vumrao
Copy link
Contributor

vumrao commented Jan 16, 2019

@liewegas Thank you Sage.

@liewegas liewegas merged commit 8a694fc into ceph:master Jan 18, 2019
liewegas added a commit that referenced this pull request Jan 18, 2019
@liewegas
Merge PR #25937 into master
4f48314 
* refs/pull/25937/head:
	qa: specify filestore for misc tests
	osd/objectstore: change osd_objectstore default to bluestore

Reviewed-by: Neha Ojha <nojha@redhat.com>
@wjwithagen
Copy link
Contributor

@liewegas
Right, guessing that this is why my jenkins runs are crashing since this morning. Bluestore on FreeBSD has not yet have all its issue ironed out.

@wjwithagen
Copy link
Contributor

@liewegas
Yup, #ifdef-ing it, gets jenkins oke again. I'll keep this in my local jenkins until bluestore really works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neha-ojha neha-ojha neha-ojha approved these changes

@dzafman dzafman Awaiting requested review from dzafman

Assignees
No one assigned
Labels
core needs-qa wip-sage-testing
Projects
None yet
Milestone
No milestone
5 participants
@liewegas @jdurgin @vumrao @wjwithagen @neha-ojha