Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: rgw: "radosgw-admin bucket rm ... --purge-objects" can hang #26263

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
4 participants
@pdvian
Copy link

commented Feb 4, 2019

rgw: `radosgw-admin bucket rm ... --purge-objects` can hang...
This command can hang (i.e., enter an infinite loop) due to
problematic bucket index entries left as a result of bug
https://tracker.ceph.com/issues/38007 .

The fix is to ignore the false bucket index entries -- since they do
not represent actual objects -- and remove all actual objects in the
bucket, so that bucket itself can be removed.

This fixes the both code paths whether `--bypass-gc` is specified or
not.

Furthermore, to made these operations more efficient, the internal
listing of the bucket is done unordered. This would improve behavior
when removing buckets with a large number of objects.

Fixes: http://tracker.ceph.com/issues/38134
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit 5b3dc38)

@smithfarm smithfarm changed the title luminous: rgw: `radosgw-admin bucket rm ... --purge-objects` can hang... luminous: rgw: "radosgw-admin bucket rm ... --purge-objects" can hang Feb 4, 2019

@smithfarm smithfarm requested review from ivancich, cbodley and theanalyst Feb 4, 2019

@smithfarm smithfarm added the rgw label Feb 4, 2019

@smithfarm smithfarm added this to the luminous milestone Feb 4, 2019

@ivancich
Copy link
Member

left a comment

Looks good!

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

@yuriw yuriw merged commit 78e440f into ceph:luminous Feb 25, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.