Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/balancer: blame if upmap won't actually work #26497

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
6 participants
@k0ste
Copy link
Contributor

commented Feb 19, 2019

mgr/balancer: blame if upmap won't actually work
With automatic balancing on, and if mode is set to upmap,
balancer will fail silently if min_compat_client is lower than
luminous.
You can't figure out that unless you take a closer look at the
mgr log, which is super annoying..

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit c7356c6)

Conflicts:
- path: src/pybind/mgr/balancer/module.py
  comment: 'set_module_option()' -> 'set_config()' for mgr config-key

@gregsfortytwo gregsfortytwo added the mgr label Mar 4, 2019

@k0ste

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

@smithfarm smithfarm requested review from liewegas and jan--f Mar 15, 2019

@smithfarm smithfarm added this to the mimic milestone Mar 15, 2019

@jan--f

jan--f approved these changes Mar 18, 2019

Copy link
Member

left a comment

👍 Similar to #26498

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@yuriw yuriw merged commit ef85320 into ceph:mimic Apr 5, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.