Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/balancer: restrict automatic balancing to specific weekdays #26499

Merged
merged 2 commits into from Jul 17, 2019

Conversation

@k0ste
Copy link
Contributor

k0ste commented Feb 19, 2019

We have implemented similar semantics for the scrub behaviour.
Let's try to keep pace with that.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn
(cherry picked from commit 0412a51)

Conflicts:

  • path: src/pybind/mgr/balancer/module.py
    comment: 'get_module_option()' -> 'get_config()' for mgr config-key
  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
@k0ste k0ste force-pushed the k0ste:mimic_backports2 branch 3 times, most recently from d1b967f to a48ac7c Feb 19, 2019
xiexingguo added 2 commits Feb 15, 2019
We have implemented similar semantics for the scrub behaviour.
Let's try to keep pace with that.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit 0412a51)

Conflicts:
- path: src/pybind/mgr/balancer/module.py
  comment: 'get_module_option()' -> 'get_config()' for mgr config-key
    'begin_weekday' and 'begin_weekday' should be int, but
    luminous/mimic config-key always return string.
The __desc__ field of **begin[end]_weekend** suggests
sunday is the prevailing start of the week, whereas the
Python implementation says no.

See https://stackoverflow.com/questions/21045569/why-is-pythons-weekday-different-from-tm-wday-in-c

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
(cherry picked from commit b9da092)
@k0ste k0ste force-pushed the k0ste:mimic_backports2 branch from a48ac7c to f4d945c Feb 23, 2019
@gregsfortytwo gregsfortytwo added the mgr label Mar 4, 2019
@k0ste

This comment has been minimized.

Copy link
Contributor Author

k0ste commented Mar 6, 2019

@stale

This comment has been minimized.

Copy link

stale bot commented May 6, 2019

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label May 6, 2019
@sebastian-philipp sebastian-philipp added this to the mimic milestone May 27, 2019
@stale stale bot removed the stale label May 27, 2019
@sebastian-philipp sebastian-philipp requested a review from votdev May 27, 2019
Copy link
Member

sebastian-philipp left a comment

looks ok, despite the diff looks weirdly different to #26501

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jul 8, 2019

@yuriw yuriw merged commit 8ac3d73 into ceph:mimic Jul 17, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.