Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/prometheus: add interface and objectstore to osd metadata #26537

Merged
merged 2 commits into from Apr 5, 2019

Conversation

Projects
None yet
5 participants
@k0ste
Copy link
Contributor

commented Feb 20, 2019

This adds three new labels to the osd_metadata metric:

  • back_iface
  • front_iface
  • objectstore

Signed-off-by: Jan Fajerski jfajerski@suse.com
(cherry picked from commit ec9dc3a)

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@tchaikov tchaikov added this to the mimic milestone Feb 20, 2019

@k0ste k0ste referenced this pull request Feb 26, 2019

Merged

mgr/prometheus: get osd_objectstore once instead twice. #26558

0 of 3 tasks complete
mgr/prometheus: add interface and objectstore to osd metadata
This adds three new labels to the osd_metadata metric:
- back_iface
- front_iface
- objectstore

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
(cherry picked from commit ec9dc3a)

@k0ste k0ste force-pushed the k0ste:mimic_backports3 branch from c0516cb to e0fad50 Feb 27, 2019

mgr/prometheus: get osd_objectstore once instead twice.
After merging #25234 & #24821 separetly we get in
get_metadata_and_osd_status() double osd_metadata.get('osd_objectstore') call.

Signed-off-by: Konstantin Shalygin <k0ste@k0ste.ru>
(cherry picked from commit bf3231b)

@k0ste k0ste force-pushed the k0ste:mimic_backports3 branch from 2aeccee to 1818f50 Feb 27, 2019

@k0ste

This comment has been minimized.

Copy link
Contributor Author

commented Mar 6, 2019

@jan--f

jan--f approved these changes Mar 18, 2019

Copy link
Member

left a comment

lgtm

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@yuriw yuriw merged commit cf71379 into ceph:mimic Apr 5, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.