Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: when exclusive lock fails due existing lock, log add'l info #26553

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
6 participants
@pdvian
Copy link

commented Feb 21, 2019

rgw: when exclusive lock fails due existing lock, log add'l info
This is being added to better understand lock-contention issues in
running systems. Here are two sample log output lines:

  2019-02-04 14:22:31.228 7f06abb59700 20 <cls>
  /somedir/ceph/src/cls/lock/cls_lock.cc:221: could not exclusive-lock
  object, already locked by [{name:client.4139,
  addr:v1:127.0.0.1:0/2034495868, exp:2019-02-04 14:24:31.0.22272s}]

  2019-02-04 14:22:37.219 7f06abb59700 20 <cls>
  /somedir/ceph/src/cls/lock/cls_lock.cc:221: could not exclusive-lock
  object, already locked by [{name:client.4147,
  addr:v1:127.0.0.1:0/141966515, exp:never}]

Fixes: http://tracker.ceph.com/issues/38171
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit af5c1ed)

@tchaikov tchaikov added this to the mimic milestone Feb 21, 2019

@smithfarm smithfarm added the rgw label Feb 22, 2019

@smithfarm smithfarm added the feature label Feb 22, 2019

@ivancich ivancich self-requested a review Feb 22, 2019

@smithfarm smithfarm requested a review from cbodley Apr 23, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@cbodley Is this feature OK to be backported to mimic?

@smithfarm smithfarm added the needs-qa label Apr 23, 2019

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@smithfarm yeah, i think this will make earlier releases easier to debug/support

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@yuriw yuriw merged commit e976412 into ceph:mimic May 3, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.