Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: MDSMonitor: do not assign standby-replay when degraded #26643

Merged
merged 1 commit into from Apr 29, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

MDSMonitor: do not assign standby-replay when degraded

The journal (or potentially other rank metadata) may be in the process of being
migrated or modified.

Fixes: http://tracker.ceph.com/issues/36384
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 065e98e)
  • Loading branch information...
batrick authored and Prashant D committed Feb 15, 2019
commit 0a99284942ea62276af57bd705ebd1326c3f8cc0
@@ -1903,9 +1903,10 @@ bool MDSMonitor::maybe_promote_standby(FSMap &fsmap, std::shared_ptr<Filesystem>
do_propose = true;
}
}
} else {
} else if (!fs->mds_map.is_degraded()) {
// There were no failures to replace, so try using any available standbys
// as standby-replay daemons.
// as standby-replay daemons. Don't do this when the cluster is degraded
// as a standby-replay daemon may try to read a journal being migrated.

// Take a copy of the standby GIDs so that we can iterate over
// them while perhaps-modifying standby_daemons during the loop
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.