Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: add --all flag to simple activate #26655

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
5 participants
@jan--f
Copy link
Member

commented Feb 26, 2019

This is intended to behave similarly to the lvm activate --all argument.
When passed, c-v will scan /etc/ceph/osd/ (or the location specified by
CEPH_VOLUME_SIMPLE_JSON_DIR) for json files (glob *.json) and call activate
for each file. This should greatly ease the take-over of ceph-disk OSDs
with manual commands and deployment tools like DeepSea and ceph-ansible.
Also adds a simple unit test and modifies the
simple/centos7/filestore/activate functional test to use --all.

Signed-off-by: Jan Fajerski jfajerski@suse.com
(cherry picked from commit 05af94c)

Conflicts:
src/ceph-volume/ceph_volume/tests/functional/simple/centos7/filestore/activate/test.yml
resolved by removing everything after conflict marker

Backport of #26225

ceph-volume: add --all flag to simple activate
This is intended to behave similarly to the lvm activate --all argument.
When passed, c-v will scan /etc/ceph/osd/ (or the location specified by
CEPH_VOLUME_SIMPLE_JSON_DIR) for json files (glob *.json) and call activate
for each file.  This should greatly ease the take-over of ceph-disk OSDs
with manual commands and deployment tools like DeepSea and ceph-ansible.
Also adds a simple unit test and modifies the
simple/centos7/filestore/activate functional test to use --all.

Signed-off-by: Jan Fajerski <jfajerski@suse.com>
(cherry picked from commit 05af94c)

 Conflicts:
	src/ceph-volume/ceph_volume/tests/functional/simple/centos7/filestore/activate/test.yml
        resolved by removing everything after conflict marker

@jan--f jan--f added this to the mimic milestone Feb 26, 2019

@jan--f jan--f requested a review from andrewschoen Feb 26, 2019

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

jenkins test ceph-volume tox

@andrewschoen

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

jenkins test ceph-volume simple all

@alfredodeza

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2019

hey @yuriw, can you confirm we can't be merging things right now because you are finalizing a mimic release? (Otherwise we don't understand why we need 6 approvals)

@LenzGr LenzGr removed the backport label Mar 29, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@alfredodeza Is this something you'd like to see included in 13.2.6 ?

@alfredodeza

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@smithfarm yes, we would like to see this merged and released as soon as possible

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@alfredodeza In the past you guys were testing and merging your own backport PRs. Has that changed?

@alfredodeza

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@smithfarm that is still the case today. When this PR was opened, 6 reviews were needed, so we were trying to make sure the process wouldn't get disrupted by a merge. I didn't realize that 6 reviews weren't required today. Thanks for following up.

@alfredodeza alfredodeza merged commit 042f80e into ceph:mimic May 6, 2019

17 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume simple testing centos7-bluestore-activate ceph-volume simple centos7-bluestore-activate OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_luks ceph-volume simple centos7-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-bluestore-dmcrypt_plain ceph-volume simple centos7-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing centos7-filestore-activate ceph-volume simple centos7-filestore-activate OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_luks ceph-volume simple centos7-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing centos7-filestore-dmcrypt_plain ceph-volume simple centos7-filestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-bluestore-activate ceph-volume simple xenial-bluestore-activate OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_luks ceph-volume simple xenial-bluestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-bluestore-dmcrypt_plain ceph-volume simple xenial-bluestore-dmcrypt_plain OK
Details
ceph-volume simple testing xenial-filestore-activate ceph-volume simple xenial-filestore-activate OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_luks ceph-volume simple xenial-filestore-dmcrypt_luks OK
Details
ceph-volume simple testing xenial-filestore-dmcrypt_plain ceph-volume simple xenial-filestore-dmcrypt_plain OK
Details
ceph-volume tox testing ceph-volume tox OK
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.