Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: Update npm packages #26670

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
6 participants
@tspmelo
Copy link
Contributor

commented Feb 27, 2019

Fix some npm packages vulnerabilities.

Fixes: http://tracker.ceph.com/issues/39080

Signed-off-by: Tiago Melo <tmelo@suse.com>

  • Vulnerability fix in karma
  • Manual test
@LenzGr

LenzGr approved these changes Feb 27, 2019

Copy link
Contributor

left a comment

LGTM - thank you!

@LenzGr LenzGr added this to the mimic milestone Feb 27, 2019

@tspmelo tspmelo force-pushed the tspmelo:wip-npm-update-mimic branch from 1a9e9b5 to 9032f77 Mar 7, 2019

@tspmelo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

jenkins retest this please

@tspmelo tspmelo force-pushed the tspmelo:wip-npm-update-mimic branch from 9032f77 to 63e31cf Mar 12, 2019

@tspmelo tspmelo marked this pull request as ready for review Mar 12, 2019

@LenzGr LenzGr added the needs-review label Mar 14, 2019

@callithea

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

jenkins test dashboard

@tspmelo tspmelo removed the DNM label Mar 22, 2019

@tspmelo tspmelo force-pushed the tspmelo:wip-npm-update-mimic branch from 63e31cf to 68fc2c0 Mar 23, 2019

@callithea
Copy link
Member

left a comment

Tested it on my local system, lgtm!

@tspmelo tspmelo added the needs-qa label Apr 2, 2019

@s0nea s0nea added the mimic-batch-1 label Apr 2, 2019

@tspmelo tspmelo force-pushed the tspmelo:wip-npm-update-mimic branch from 68fc2c0 to 32cb38a Apr 2, 2019

@tspmelo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

I updated the commit messages with the reference to the tracker issue.

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@tspmelo this PR seem to be breaking build
Pls take a look add add back tags when ready

This is built only with this PR on top of mimic
https://shaman.ceph.com/builds/ceph/wip_yuriw_mimic_PR26670/

@tspmelo tspmelo force-pushed the tspmelo:wip-npm-update-mimic branch from 32cb38a to b50ecf0 Apr 10, 2019

@tspmelo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

Only had a quick look at the logs yesterday, today they were already gone.
The problem was related to the version of npm, which needs to be a higher version than the one that was being used in shaman.
Strange that it is working in make check but failed in shaman.

I have updated the node version to the same we use in master, hopefully it will work now.

@callithea

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

jenkins test dashboard

1 similar comment
@tspmelo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 10, 2019

jenkins test dashboard

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

The tracker has a nice explanation of why these commits can't be cherry-picked: "We need to manually update the npm packages in mimic. It's not possible to do a backport since we don't use the same packages anymore."

However, that explanation will not be visible to anyone reading the git history and wondering why these are not cherry-picks. Could we get the explanation in the commit messages themselves, please?

@smithfarm smithfarm added the needs-qa label Apr 10, 2019

@tspmelo tspmelo force-pushed the tspmelo:wip-npm-update-mimic branch from b50ecf0 to f2db8a5 Apr 11, 2019

@tspmelo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

@smithfarm Done.

@tspmelo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

jenkins test dashboard

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@tspmelo @smithfarm I still can't built this.
wip-yuri5-testing-2019-04-30-1634-mimic has only this PR on the top of the tip and is failing => https://shaman.ceph.com/builds/ceph/wip-yuri5-testing-2019-04-30-1634-mimic/

tspmelo added some commits Feb 27, 2019

mgr/dashboard: Update npm packages
Fix some npm packages vulnerabilities.

Since we don't use the same npm packages anymore, it's not possible to backport
this changes from master to mimic.

Fixes: http://tracker.ceph.com/issues/39080

Signed-off-by: Tiago Melo <tmelo@suse.com>
mgr/dashboard: Add package-lock.json and use "npm ci"
This will make sure that in the future we always install the same version
of every npm package.

Since we don't use the same npm packages anymore, it's not possible to backport
this changes from master to mimic.

Fixes: http://tracker.ceph.com/issues/39080

Signed-off-by: Tiago Melo <tmelo@suse.com>

@tspmelo tspmelo force-pushed the tspmelo:wip-npm-update-mimic branch from f2db8a5 to 44f3833 Apr 30, 2019

@tspmelo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

@yuriw sorry about this.

Last time I was not able to check the logs, since they were gone in the morning, and was not able to figure out why this was working in make check and failing in shaman.

After a look a the logs and a quick search of mimic code I found out that although I had fixed the problem in CMakeLists.txt, I forgot to fix it in make-dist script.

I have updated make-dist and hopefully it will work on all envs now.

@yuriw yuriw added the needs-qa label Apr 30, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@tspmelo cool I will test

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@tspmelo looks good now! will batch it up with other PRs and run thru suites

FYI https://shaman.ceph.com/builds/ceph/wip-yuri5-testing-2019-04-30-1715-mimic/

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@yuriw yuriw merged commit 39e2070 into ceph:mimic May 3, 2019

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details

@tspmelo tspmelo deleted the tspmelo:wip-npm-update-mimic branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.