Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: rgw_file: use correct secret key to check auth #26687

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
6 participants
@pdvian
Copy link

commented Feb 28, 2019

rgw_file: use correct secret key to check auth
Currently, the authorize function in rgw_file only use the secret key of
first key pair to compare, add a function which get secret key by user's
access key and check the result is match with user's secret key.

Fixes: https://tracker.ceph.com/issues/37855

Signed-off-by: MinSheng Lin <minsheng.l@inwinstack.com>
(cherry picked from commit e92755c)
@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

155/156 Test #122: mgr-dashboard-frontend-unittests ........***Failed

Looks unrelated

@smithfarm smithfarm added this to the mimic milestone Mar 1, 2019

@smithfarm smithfarm added the rgw label Mar 1, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

jenkins re-test this please

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

155/156 Test #122: mgr-dashboard-frontend-unittests ........***Failed

Again.

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

@callithea Looks like the mgr/dashboard "make check" is somewhat broken on the tip of mimic :-(

@callithea

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

@callithea Looks like the mgr/dashboard "make check" is somewhat broken on the tip of mimic :-(

@smithfarm was the previous error the same?
Created https://tracker.ceph.com/issues/38602

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

@callithea Apparently not. The other error is tracked by http://tracker.ceph.com/issues/38590.

@smithfarm smithfarm requested a review from mattbenjamin Mar 7, 2019

@smithfarm smithfarm changed the title mimic: rgw_file: use correct secret key to check auth mimic: rgw: rgw_file: use correct secret key to check auth Mar 7, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

jenkins test make check

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

@yuriw yuriw merged commit ed413f7 into ceph:mimic Mar 19, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.