Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: fix for using '::' on hosts without ipv6 #26750

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
6 participants
@noahdesu
Copy link
Member

commented Mar 4, 2019

https://tracker.ceph.com/issues/38588


CherryPy throws an uncaught exception using '::' when the host does not
have an ipv6 loopback address. This is currently the case in kubernetes.
This patch disables the routine in cherrypy that performs the validation
that requested server ports are actually bound.

fixes: http://tracker.ceph.com/issues/38575

Signed-off-by: Noah Watkins noahwatkins@gmail.com
(cherry picked from commit 384d82a)

mgr/dashboard: fix for using '::' on hosts without ipv6
CherryPy throws an uncaught exception using '::' when the host does not
have an ipv6 loopback address. This is currently the case in kubernetes.
This patch disables the routine in cherrypy that performs the validation
that requested server ports are actually bound.

fixes: http://tracker.ceph.com/issues/38575

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
(cherry picked from commit 384d82a)

@noahdesu noahdesu changed the title backport: mgr/dashboard: fix for using '::' on hosts without ipv6 mimic: mgr/dashboard: fix for using '::' on hosts without ipv6 Mar 4, 2019

@noahdesu noahdesu changed the title mimic: mgr/dashboard: fix for using '::' on hosts without ipv6 backport: mimic: mgr/dashboard: fix for using '::' on hosts without ipv6 Mar 4, 2019

@noahdesu noahdesu added this to the mimic milestone Mar 4, 2019

@callithea callithea added the backport label Mar 5, 2019

@smithfarm smithfarm removed the backport label Mar 5, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

Please don't use the "backport" label - it's confusing. We use Milestone to track backport PRs.

@smithfarm smithfarm changed the title backport: mimic: mgr/dashboard: fix for using '::' on hosts without ipv6 mimic: mgr/dashboard: fix for using '::' on hosts without ipv6 Mar 5, 2019

@smithfarm smithfarm requested a review from LenzGr Mar 5, 2019

@votdev

votdev approved these changes Mar 22, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@noahdesu

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2019

hey @yuriw i'm not sure what the trello link is but i don't seem to be able to access it. do i need to look at it?

@yuriw yuriw merged commit 168ea1f into ceph:mimic Apr 5, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.