Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: data sync drains lease stack on lease failure #26762

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
5 participants
@pdvian
Copy link

commented Mar 5, 2019

rgw: data sync drains lease stack on lease failure
on lease failure, call drain_all() to collect the spawned lease stack.
otherwise, the parent coroutine will inherit this spawned stack and may
not drain or collect it manually. RGWDataSyncShardControlCR, for
example, does not drain/collect because it only uses call() to run a
single RGWDataSyncShardCR, so all lease stacks from RGWDataSyncShardCR
just pile up in the RGWDataSyncShardControlCR

Fixes: http://tracker.ceph.com/issues/38479

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 11ff865)

@smithfarm smithfarm added this to the mimic milestone Mar 5, 2019

@smithfarm smithfarm added the rgw label Mar 5, 2019

@smithfarm smithfarm requested review from cbodley and yehudasa Mar 5, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 5, 2019

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! ceph-dashboard@0.0.0 build: `ng build "--prod"`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the ceph-dashboard@0.0.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/jenkins-build/.npm/_logs/2019-03-05T05_49_15_864Z-debug.log
src/pybind/mgr/dashboard/CMakeFiles/mgr-dashboard-frontend-build.dir/build.make:1435: recipe for target '../src/pybind/mgr/dashboard/frontend/dist' failed
make[3]: *** [../src/pybind/mgr/dashboard/frontend/dist] Error 1
CMakeFiles/Makefile2:4878: recipe for target 'src/pybind/mgr/dashboard/CMakeFiles/mgr-dashboard-frontend-build.dir/all' failed

@callithea @ricardoasmarques @sebastian-philipp Any idea why "make check" is now failing with the above error on (all?) mimic PRs?

@sebastian-philipp

This comment has been minimized.

@cbodley

cbodley approved these changes Mar 5, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

I marked https://tracker.ceph.com/issues/38602 as related - I did not examine the failures closely, but it looks like there are two ways that mgr-dashboard-frontend-unittests is failing on the tip of mimic.

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

jenkins re-test this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@yuriw yuriw merged commit d035c2f into ceph:mimic May 15, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.