Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: common/str_map: fix trim() on empty string #26810

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
7 participants
@ashishkumsingh
Copy link
Contributor

commented Mar 7, 2019

liewegas added some commits Feb 28, 2019

common/str_map: fix trim() on empty string
If was pass an empty string (e.g., with something like
get_str_map("M= T= P=")) we end up with a (size_t)-1 for end.

Fixes: http://tracker.ceph.com/issues/38329
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 16ffca6)
common/str_map: better trim() impl using boost
Thanks Kefu!

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 6154874)

@ashishkumsingh ashishkumsingh added this to the mimic milestone Mar 7, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

mimic test make check

@smithfarm smithfarm added the common label Mar 7, 2019

@smithfarm smithfarm requested review from badone, neha-ojha and tchaikov Mar 7, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

jenkins test make check

@neha-ojha neha-ojha added the needs-qa label Mar 7, 2019

@badone

badone approved these changes Mar 9, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@yuriw yuriw merged commit c8bfae9 into ceph:mimic May 2, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.