Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: run-standalone.sh: Need double-quotes to handle | in core_pattern on all distributions #26811

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
4 participants
@ashishkumsingh
Copy link
Contributor

commented Mar 7, 2019

dzafman added some commits Feb 15, 2019

Revert "qa/standalone: discard pipe in sysctl kernel.core_pattern"
This reverts commit 5ba6286.

Signed-off-by: David Zafman <dzafman@redhat.com>

Conflicts:
	qa/run-standalone.sh (reseting core_pattern moved to function)
(cherry picked from commit c7dd854)
run-standalone.sh: Need double-quotes to handle | in core_pattern
on all distributions

OpenSUSE does not automatically add the | back when setting
the corepattern.  I tested this on openSUSE Leap 15.0.

Fixes: http://tracker.ceph.com/issues/38325

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit bc2df8c)

@ashishkumsingh ashishkumsingh added this to the mimic milestone Mar 7, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

compilation error will be fixed by #26814

@smithfarm smithfarm added the tests label Mar 7, 2019

@smithfarm smithfarm requested review from dzafman and smithfarm Mar 7, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

jenkins test make check

@dzafman

dzafman approved these changes Mar 7, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

jenkins re-test this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@yuriw yuriw merged commit f194aea into ceph:mimic May 2, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.