Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: run-standalone.sh: Need double-quotes to handle | in core_pattern on all distributions #26811

Merged
merged 2 commits into from May 2, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

run-standalone.sh: Need double-quotes to handle | in core_pattern

on all distributions

OpenSUSE does not automatically add the | back when setting
the corepattern.  I tested this on openSUSE Leap 15.0.

Fixes: http://tracker.ceph.com/issues/38325

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit bc2df8c)
  • Loading branch information...
dzafman authored and ashishkumsingh committed Feb 15, 2019
commit 8757f2cf2fe5dca77fe93100784a54bc702a0d54
@@ -46,7 +46,7 @@ fi

function cleanup() {
if [ -n "$precore" ]; then
sudo sysctl -w ${KERNCORE}=${precore}
sudo sysctl -w "${KERNCORE}=${precore}"
fi
}

@@ -87,7 +87,7 @@ precore="$(sysctl -n $KERNCORE)"
if [ "$precore" = "$COREPATTERN" ]; then
precore=""
else
sudo sysctl -w ${KERNCORE}=${COREPATTERN}
sudo sysctl -w "${KERNCORE}=${COREPATTERN}"
fi
# Clean out any cores in core target directory (currently .)
if ls $(dirname $(sysctl -n $KERNCORE)) | grep -q '^core\|core$' ; then
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.