Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: Search broken for entries with null values #26944

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
5 participants
@ashishkumsingh
Copy link
Contributor

commented Mar 14, 2019

mgr/dashboard: Search broken for entries with null values
Fixes: http://tracker.ceph.com/issues/38583

Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
(cherry picked from commit ee988b9)

Conflicts:
	- src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts
	    Modified the file to keep changes to relevant to this version.

@ashishkumsingh ashishkumsingh added this to the mimic milestone Mar 14, 2019

@smithfarm smithfarm requested review from p-na and LenzGr Mar 14, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

@p-na

p-na approved these changes Mar 15, 2019

@LenzGr

LenzGr approved these changes Mar 19, 2019

Copy link
Contributor

left a comment

LGTM - thank you!

@yuriw yuriw merged commit da4ec58 into ceph:mimic Mar 19, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.