Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-volume: look for rotational data in lsblk #26991

Merged
merged 1 commit into from Jul 25, 2019

Conversation

@andrewschoen
Copy link
Contributor

andrewschoen commented Mar 15, 2019

Also ask lsblk if a device is rotational if no information
is found in /sys/block, default to True if nothing is found.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1666822

Signed-off-by: Andrew Schoen aschoen@redhat.com
(cherry picked from commit de748f9)

backport of #26957

@tchaikov tchaikov added this to the mimic milestone Mar 19, 2019
@andrewschoen andrewschoen force-pushed the backport-mimic-26957 branch from 559a780 to cd3daa3 Apr 23, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Apr 23, 2019

jenkins re-test this please

@andrewschoen andrewschoen requested a review from alfredodeza Apr 23, 2019
@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Apr 23, 2019

jenkins test ceph-volume lvm all

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Apr 23, 2019

jenkins test ceph-volume simple all

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Apr 23, 2019

jenkins test ceph-volume tox

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Jul 9, 2019

jenkins test ceph-volume tox

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Jul 9, 2019

I'm thinking this needs a different version of ceph-ansible right?

The conditional check 'is_atomic' failed. The error was: error while evaluating conditional (is_atomic): 'is_atomic' is undefined
@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Jul 10, 2019

I poked around but I can't tell what the problem is with the ceph-ansible error @andrewschoen

Any pointers (or maybe this just needs a rebase)?

@andrewschoen andrewschoen force-pushed the backport-mimic-26957 branch from cd3daa3 to fa99836 Jul 10, 2019
@andrewschoen

This comment has been minimized.

Copy link
Contributor Author

andrewschoen commented Jul 10, 2019

jenkins test ceph-volume tox

@andrewschoen

This comment has been minimized.

Copy link
Contributor Author

andrewschoen commented Jul 10, 2019

jenkins test ceph-volume lvm all

@andrewschoen

This comment has been minimized.

Copy link
Contributor Author

andrewschoen commented Jul 10, 2019

jenkins test ceph-volume simple all

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Jul 17, 2019

jenkins test ceph-volume lvm all

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Jul 17, 2019

jenkins test ceph-volume simple all

@alfredodeza

This comment has been minimized.

Copy link
Contributor

alfredodeza commented Jul 24, 2019

This needs a rebase

Also ask lsblk if a device is rotational if no information
is found in /sys/block, default to True if nothing is found.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1666822

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit de748f9)
@andrewschoen andrewschoen force-pushed the backport-mimic-26957 branch from fa99836 to 2d81ec2 Jul 25, 2019
@andrewschoen

This comment has been minimized.

Copy link
Contributor Author

andrewschoen commented Jul 25, 2019

jenkins test ceph-volume batch all

@andrewschoen

This comment has been minimized.

Copy link
Contributor Author

andrewschoen commented Jul 25, 2019

jenkins test ceph-volume tox

@alfredodeza alfredodeza merged commit 1a57bba into mimic Jul 25, 2019
13 of 21 checks passed
13 of 21 checks passed
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt_explicit ceph-volume batch centos7-bluestore-mixed_type_dmcrypt_explicit failed
Details
ceph-volume batch testing centos7-bluestore-mixed_type_explicit ceph-volume batch centos7-bluestore-mixed_type_explicit failed
Details
ceph-volume batch testing centos7-bluestore-single_type ceph-volume batch centos7-bluestore-single_type failed
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt_explicit ceph-volume batch centos7-filestore-mixed_type_dmcrypt_explicit failed
Details
ceph-volume batch testing centos7-filestore-mixed_type_explicit ceph-volume batch centos7-filestore-mixed_type_explicit failed
Details
ceph-volume batch testing xenial-bluestore-single_type ceph-volume batch xenial-bluestore-single_type failed
Details
ceph-volume tox testing ceph-volume tox failed
Details
make check running make check
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume batch testing centos7-bluestore-mixed_type ceph-volume batch centos7-bluestore-mixed_type OK
Details
ceph-volume batch testing centos7-bluestore-mixed_type_dmcrypt ceph-volume batch centos7-bluestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-bluestore-single_type_dmcrypt ceph-volume batch centos7-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-mixed_type ceph-volume batch centos7-filestore-mixed_type OK
Details
ceph-volume batch testing centos7-filestore-mixed_type_dmcrypt ceph-volume batch centos7-filestore-mixed_type_dmcrypt OK
Details
ceph-volume batch testing centos7-filestore-single_type ceph-volume batch centos7-filestore-single_type OK
Details
ceph-volume batch testing centos7-filestore-single_type_dmcrypt ceph-volume batch centos7-filestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-bluestore-single_type_dmcrypt ceph-volume batch xenial-bluestore-single_type_dmcrypt OK
Details
ceph-volume batch testing xenial-filestore-single_type ceph-volume batch xenial-filestore-single_type OK
Details
ceph-volume batch testing xenial-filestore-single_type_dmcrypt ceph-volume batch xenial-filestore-single_type_dmcrypt OK
Details
@alfredodeza alfredodeza deleted the backport-mimic-26957 branch Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.