Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mgr/dashboard: show I/O stats in Pool list #27053

Merged
merged 1 commit into from Mar 27, 2019

Conversation

Projects
None yet
5 participants
@alfonsomthd
Copy link
Contributor

commented Mar 19, 2019

  • Applied same fix as in nautilus.
  • Adapted Pool list columns to avoid constant resizing.
  • Added 'decimals' argument to dimless pipe in order for
    stats to fit in Pool list columns.

Fixes: https://tracker.ceph.com/issues/38284

Signed-off-by: Alfonso Martínez almartin@redhat.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@alfonsomthd alfonsomthd force-pushed the rhcs-dashboard:38284-mimic-show-io-stats branch from b51a400 to f4befe8 Mar 20, 2019

@callithea callithea added this to the mimic milestone Mar 20, 2019

@LenzGr LenzGr added the needs-review label Mar 20, 2019

@callithea

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

jenkins test dashboard

mgr/dashboard: mimic fix: show I/O stats in Pool list
* Applied same fix as in nautilus.
* Adapted Pool list columns to avoid constant resizing.
* Added 'decimals' argument to dimless pipe in order for
  stats to fit in Pool list columns.

Fixes: https://tracker.ceph.com/issues/38284

Signed-off-by: Alfonso Martínez <almartin@redhat.com>

@alfonsomthd alfonsomthd force-pushed the rhcs-dashboard:38284-mimic-show-io-stats branch from f4befe8 to 9f67de8 Mar 21, 2019

@alfonsomthd

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

mimic-pool-list-io-stats

@tspmelo
Copy link
Contributor

left a comment

lgtm

@tchaikov tchaikov changed the title mgr/dashboard: mimic fix: show I/O stats in Pool list mimic: mgr/dashboard: show I/O stats in Pool list Mar 27, 2019

@callithea
Copy link
Member

left a comment

Tested it on my local system, lgtm!

@LenzGr LenzGr merged commit fde9883 into ceph:mimic Mar 27, 2019

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph dashboard tests ceph dashboard tests succeeded
Details
make check make check succeeded
Details

@alfonsomthd alfonsomthd deleted the rhcs-dashboard:38284-mimic-show-io-stats branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.