Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: test/store_test: fix/workaround for BlobReuseOnOverwriteUT and garbageCollection #27055

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
5 participants
@ifed01
Copy link
Contributor

commented Mar 19, 2019

So we just postpone the execution to allow cache autotuning to balance properly.

Workarounds: https://tracker.ceph.com/issues/38795

Signed-off-by: Igor Fedotov ifedotov@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@ifed01 ifed01 force-pushed the ifed01:wip-ifed-fix-storetest-mimic branch from acb2a16 to 08b6038 Mar 20, 2019

@tchaikov tchaikov added this to the mimic milestone Mar 20, 2019

@ifed01 ifed01 changed the title mimic: test/store_test: workaround for failing BlobReuseOnOverwrite UT mimic: test/store_test: fix/workaround for BlobReuseOnOverwriteUT and garbageCollection Mar 20, 2019

@ifed01 ifed01 requested a review from liewegas Mar 20, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@ifed01 In the commit message of the first commit, could you explain why the fix (workaround) cannot be applied to master and cherry-picked to mimic?

Perhaps just by copy-pasting this sentence: "Nautilus+ releases doesn't have the issue which is probably related to modifications of BlueStore::MempoolThread::_trim_shards which introduces different calculation for meta|data_alloc parameters."

@ifed01 ifed01 force-pushed the ifed01:wip-ifed-fix-storetest-mimic branch from 52f57c2 to 5f327ac Apr 24, 2019

@ifed01

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@smithfarm - done

ifed01 added some commits Mar 19, 2019

mimic: test/store_test: workaround for failing BlobReuseOnOverwrite UT
Workarounds: https://tracker.ceph.com/issues/38795

Nautilus+ releases doesn't have the issue which is probably related to
modifications of BlueStore::MempoolThread::_trim_shards which introduces
different calculation for meta|data_alloc parameters

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
os/tests: fix garbageCollection test case from store_test.
While running the test case using SSD as block device one could face
a failure caused by unexpectidly small blob size limit - compression
resulted in two blocks rather than single one which violated was test case
constraints.

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit d7b45b6)

@ifed01 ifed01 force-pushed the ifed01:wip-ifed-fix-storetest-mimic branch from 5f327ac to 0c02a56 Apr 25, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@yuriw yuriw merged commit d713a9d into ceph:mimic May 8, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@ifed01 ifed01 deleted the ifed01:wip-ifed-fix-storetest-mimic branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.