Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: crush/CrushWrapper: ensure crush_choose_arg_map.size == max_buckets #27082

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
5 participants
@pdvian
Copy link

commented Mar 21, 2019

crush/CrushWrapper: ensure crush_choose_arg_map.size == max_buckets
The crush/builder.c crush_add_bucket method resizes the max_buckets array
but a power of 2 when it has to expand, but the code in CrushWrapper was
assuming that if the array grew the pos for the new bucket would be the
last position in the new array.  This led to a situation where the
crush_choose_arg_map args array size didn't match max_buckets, and
eventually caused a crash.

Fixes: http://tracker.ceph.com/issues/38664
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit ccda488)

Conflicts:
	src/crush/CrushWrapper.cc : Resolved in add_bucket

@tchaikov tchaikov added this to the mimic milestone Mar 21, 2019

@smithfarm smithfarm requested a review from liewegas Mar 22, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@yuriw yuriw merged commit cf41e71 into ceph:mimic Apr 5, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.