Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One Rados Handle to Rule Them All #27102

Merged

Conversation

adamemerson
Copy link
Contributor

Remove deprecated num_rados_handles option and code to support it.

@cbodley
Copy link
Contributor

cbodley commented Mar 21, 2019

thanks @adamemerson! can you please remove the rgw num rados handles section from doc/radosgw/config-ref.rst?

i'd also like to see some kind of documentation for users that relied on handles > 0, so they know to adjust their objecter tunings accordingly - i think PendingReleaseNotes is probably the right place for that

@adamemerson
Copy link
Contributor Author

@cbodley Do we know what advice to give them? (Or who to ask? Should I mail Kyle Bader or do we have something written up?)

@cbodley
Copy link
Contributor

cbodley commented Mar 21, 2019

@adamemerson you can just say that given rgw_num_rados_handles=N, they should multiply their objecter_inflight_ops and objecter_inflight_op_bytes by N to get the same overall throttle tunings

This has been deprecated for some time and underlies much of the
complexity of the RADOS service.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Since we aren't supporting multiple handles, don't have the overhead.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
@adamemerson adamemerson force-pushed the wip-one-rados-handle-to-rule-them-all branch from df790cf to 5666b4c Compare March 21, 2019 19:14
@adamemerson
Copy link
Contributor Author

@cbodley All right! It is done.

Copy link
Contributor

@cbodley cbodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍭 🐐 🌮 💸

@cbodley
Copy link
Contributor

cbodley commented Mar 22, 2019

@cbodley cbodley merged commit f038e18 into ceph:master Mar 22, 2019
@adamemerson adamemerson deleted the wip-one-rados-handle-to-rule-them-all branch June 17, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants