Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: GetBucketCORS API returns Not Found error code when CORS configuration does not exist #27122

Merged
merged 2 commits into from May 3, 2019

Conversation

Projects
None yet
6 participants
@smithfarm
Copy link
Contributor

commented Mar 22, 2019

joke-lee and others added some commits Aug 6, 2018

rgw: cors rules num limit
According to AWS S3, an cors rules can
have up to 100 rules.

Signed-off-by: yuliyang <yuliyang@cmss.chinamobile.com>
(cherry picked from commit c97ee93)
rgw: the error code returned by rgw is different from amz s3 when
getting cors from the bucket without cors configuration

Fixes: http://tracker.ceph.com/issues/26964

Signed-off-by: ashitakasam <694240887@qq.com>
(cherry picked from commit 009a67f)

Conflicts:
	src/rgw/rgw_op.cc
- mimic uses dout(2) instead of ldpp_dout(this, 2)

@smithfarm smithfarm self-assigned this Mar 22, 2019

@smithfarm smithfarm added this to the mimic milestone Mar 22, 2019

@smithfarm smithfarm requested a review from cbodley Mar 22, 2019

@smithfarm smithfarm added rgw and removed bug fix core labels Mar 22, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@cbodley Cherry-picking c97ee93 first seemed to be the right thing to do here, but perhaps it's not necessary/desirable?

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@cbodley
Copy link
Contributor

left a comment

thanks @smithfarm - may as well include the cors limit too

@vumrao

This comment has been minimized.

Copy link
Contributor

commented Mar 22, 2019

thanks @smithfarm

@smithfarm smithfarm changed the title mimic: GetBucketCORS API returns Not Found error code when CORS configuration does not exist mimic: rgw: GetBucketCORS API returns Not Found error code when CORS configuration does not exist Apr 12, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@yuriw yuriw merged commit 1765f81 into ceph:mimic May 3, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-38886-mimic branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.