Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: shutdown recovery_request_timer earlier #27206

Merged
merged 1 commit into from Apr 1, 2019

Conversation

@Aran85
Copy link

commented Mar 27, 2019

recovery_request_timer may hold some QueuePeeringEvts which PGRef,
if we dont shutdown it earlier, it potentially cause the PGRef leak
when kicking pg.

Fixes: https://tracker.ceph.com/issues/38945

Signed-off-by: Zengran Zhang zhangzengran@sangfor.com.cn

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Zengran Zhang
osd: shutdown recovery_request_timer earlier
recovery_request_timer may hold some QueuePeeringEvts which PGRef,
if we dont shutdown it earlier, it potentially cause the PGRef leak
when kicking pg.

Fixes: https://tracker.ceph.com/issues/38945

Signed-off-by: Zengran Zhang <zhangzengran@sangfor.com.cn>
@Aran85

This comment has been minimized.

Copy link
Author

commented Mar 27, 2019

@tchaikov @liewegas does this make sense?

@tchaikov
Copy link
Contributor

left a comment

as a side note, that's also the reason why we added OSDService::start_shutdown() in c0dc245 .

@liewegas liewegas merged commit bb41bdf into ceph:master Apr 1, 2019

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
liewegas added a commit that referenced this pull request Apr 1, 2019
Merge PR #27206 into master
* refs/pull/27206/head:
	osd: shutdown recovery_request_timer earlier

Reviewed-by: Kefu Chai <kchai@redhat.com>

@Aran85 Aran85 deleted the Aran85:fix-pg-leak branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.