Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: msgr: should set EPOLLET flag on del_event() #27226

Merged
merged 2 commits into from Mar 29, 2019

Conversation

Projects
None yet
6 participants
@pdvian
Copy link

commented Mar 28, 2019

rouming added some commits Mar 5, 2019

EventEpoll: set EPOLLET flag on del_event()
When new fd is being added to epoll fd EPOLLET (edge triggered) flag
is set, i.e. we assume that in and out works in edge triggered mode.

But on del_event(), when eventually epoll_ctl(EPOLL_CTL_MOD) is
invoked, EPOLLET flag is cleared, i.e. level triggered mode is
enabled.

Do not lose EPOLLET.

Signed-off-by: Roman Penyaev <rpenyaev@suse.de>
(cherry picked from commit c415b9f)
EventEpoll: refactor del_event() a bit
The main purpose of the patch is to set 'ee' members only on EPOLL_CTL_MOD
path, deletion path does not requie any of the members set.

This will make code a bit better.

Signed-off-by: Roman Penyaev <rpenyaev@suse.de>
(cherry picked from commit 2292120)
@yuriw

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@yuriw yuriw merged commit 531d8c3 into ceph:luminous Mar 29, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm added messenger and removed common labels Mar 30, 2019

@smithfarm smithfarm changed the title luminous: should set EPOLLET flag on del_event() luminous: msgr: should set EPOLLET flag on del_event() Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.