Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: ceph-disk/tests: use random unused port for CEPH_MON #27228

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
4 participants
@tchaikov
Copy link
Contributor

commented Mar 28, 2019

Fixes: http://tracker.ceph.com/issues/39066
Signed-off-by: Kefu Chai kchai@redhat.com

Conflicts:
src/ceph-disk/tests/ceph-disk.sh: this change is not
cherry-picked from master. because ceph-disk was removed in nautilus. and
we need to run multiple luminous tests in parallel, hence the change.

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@tchaikov tchaikov added the tests label Mar 28, 2019

@tchaikov tchaikov added this to the mimic milestone Mar 28, 2019

@tchaikov tchaikov requested a review from yuriw Mar 28, 2019

@alfredodeza
Copy link
Contributor

left a comment

I guess this get_unused_port is a utility that is already sourced from somewhere? This is fine I think!

@yuriw

yuriw approved these changes Mar 28, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@smithfarm @theanalyst we need luminous' backport and maybe nautilus` ?

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@yuriw Definitely not to nautilus. Whether it needs to be backported to luminous, @tchaikov would know better.

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Mar 28, 2019

@smithfarm he already said so

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

yeah, i agree with @smithfarm , we don't need this change in nautilus.

and i think we will need it in luminous.

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@tchaikov Can we have a new tracker instead of reusing an old one?

Sage's pattern for follow-up fixes is

Fixes: [SHA1]

which is better than "Fixes: [TRACKER URL]" because having follow-up fixes mention the original tracker makes them hard to backport...

ceph-disk/tests: use random unused port for CEPH_MON
Fixes: http://tracker.ceph.com/issues/39066
Signed-off-by: Kefu Chai <kchai@redhat.com>

Conflicts:
	src/ceph-disk/tests/ceph-disk.sh: this change is not
cherry-picked from master. because ceph-disk was removed in nautilus. and
we need to run multiple luminous tests in parallel, hence the change.
@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 1, 2019

@tchaikov tchaikov force-pushed the tchaikov:mimic-36737 branch from 1d0b15a to 3ea544f Apr 1, 2019

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

retest this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@yuriw yuriw merged commit 23c3143 into ceph:mimic Apr 17, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:mimic-36737 branch Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.