Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: crush: add root_bucket to identify underfull buckets #27257

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
5 participants
@pdvian
Copy link

commented Mar 29, 2019

huangjun Prashant D
crush: add root_bucket to identify underfull buckets
All underfull buckets under root_buckets will be taken as target

For the crule rule:
    step take datacenter0
    step chooseleaf firstn 2 type host
    step emit
    step take datacenter1
    step chooseleaf firstn 2 type host
    step emit

If one host contains overfull osd but no underfull osd,
it will use other underfull buckets as target, which
maybe not in the same datacenter, that will
broke the rule.

Fixes: http://tracker.ceph.com/issues/38826

Signed-off-by: huangjun <huangjun@xsky.com>
(cherry picked from commit 3d5678d)

@tchaikov tchaikov added this to the mimic milestone Mar 29, 2019

@smithfarm smithfarm requested review from xiexingguo and liewegas Mar 29, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@yuriw yuriw merged commit 28bb5d3 into ceph:mimic Apr 5, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.