Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: os/bluestore: bitmap allocator might fail to return contiguous chunk despite having enough space #27298

Merged
merged 5 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@ifed01
Copy link
Contributor

commented Apr 1, 2019

ifed01 added some commits Mar 12, 2019

os/bluestore: os/bluestore: implement dump for bitmap allocator
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit 80310d9)
tests/fastbmap_alloc: UT to reproduce 4G allocation bug
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit ed8a93b)
os/bluestore: make bluestore interval base template.
We might need intervals at BlueStore with both 32-bit and 64-bit
lengths. Having base template eliminates the need for copy/paste

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit f775d42)
os/bluestore: start using 64-bit intervals for bitmap allocator
This helps to avoid 4Gb+ values wrapping which resulted in
allocation failures.

Fixes: https://tracker.ceph.com/issues/38761

Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit d146696)
os/bluestore: unconditionally cap chunks returned by allocator to 2^31
Signed-off-by: Igor Fedotov <ifedotov@suse.com>
(cherry picked from commit 1337443)

@liewegas liewegas added this to the mimic milestone Apr 2, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

@ifed01 ifed01 requested a review from liewegas Apr 11, 2019

@yuriw yuriw merged commit 1661231 into ceph:mimic Apr 12, 2019

3 of 4 checks passed

Signed-off-by Build triggered for merge commit.
Details
Docs: build check OK - docs built
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@ifed01 ifed01 deleted the ifed01:wip-ifed-alloc-issues-mimic branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.