Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rgw: fix bug of apply default quota, for this create new a user may core using beast #27335

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
4 participants
@liaoxin01
Copy link

commented Apr 3, 2019

rgw: fix bug of apply default quota, for this create new a user may core using beast

Fixes: f2779e5
Fixes: http://tracker.ceph.com/issues/38847
Signed-off-by: liaoxin01 liaoxin01@baidu.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
liaoxin01
rgw: fix bug of apply default quota, for this create new a user may c…
…ore using beast

Signed-off-by: liaoxin01 <liaoxin01@baidu.com>

@smithfarm smithfarm requested a review from cbodley Apr 10, 2019

@smithfarm smithfarm added this to the mimic milestone Apr 10, 2019

@smithfarm smithfarm added the rgw label Apr 10, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

@liaoxin01 So this bug does not exist in master? Can you point to the commit(s) that fixed it there?

(Background: we always try to fix all bugs in master, first, and backport the fixes from there to the stable branches like mimic)

@smithfarm smithfarm changed the title rgw: fix bug of apply default quota, for this create new a user may core using beast mimic: rgw: fix bug of apply default quota, for this create new a user may core using beast Apr 10, 2019

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

thanks @smithfarm. it looks like this change doesn't apply to master because CephContext's md_config_t *_conf was changed to ConfigProxy _conf. i don't understand how the mimic branch even compiles without this change, as we're passing md_config_t* to functions that expect const md_config_t&:

void rgw_apply_default_bucket_quota(RGWQuotaInfo& quota, const md_config_t& conf);
void rgw_apply_default_user_quota(RGWQuotaInfo& quota, const md_config_t& conf);

my only guess is that the md_config_t::md_config_t(bool is_daemon=false) constructor is implicitly converting md_config_t* to bool

it looks like the luminous backport was done differently, taking this last parameter as const CephContext* cct instead of cct->_conf

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

it looks like the luminous backport was done differently

@cbodley But which luminous backport is that? (If there's an existing tracker issue that was backported, it might make sense to associate this backport with it?)

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@liaoxin01 Could you add the following line to the commit message?

Fixes: f2779e5a3d74b7bacdbbe1619d18ccdf24798ae0

(This could be immediately above the existing line Fixes: http://tracker.ceph.com/issues/38847)

Rationale: the commit message should make it clear that this is a follow-up fix for a backport.

@cbodley

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

ping @liaoxin01 can you please address @smithfarm's comment?

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@yuriw yuriw merged commit e74b165 into ceph:mimic May 3, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.